feat: add get_invoice_funding_progress, harden get_invoice_phase (#67… - #710
Merged
Kingsman-99 merged 1 commit intoAug 29, 2026
Merged
Conversation
|
@Maki-Zeninn Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…4, #676)
closes #674
closes #675
closes #676
closes #677
Summary
get_invoice_funding_progress(invoice_id) -> Result<u32, ContractError>— funded*10_000/total in bps, clamped to [0, 10_000], 0 when total is 0, InvoiceNotFound for unknown ids. (Add get_invoice_funding_progress view function #674)get_invoice_phaseto returnResult<InvoicePhase, ContractError>(was infallible, silently defaulted unknown ids to Draft) and to derive the phase from invoice state when no phase was ever explicitly set viaset_invoice_phase. (Add get_invoice_phase view function #676)get_creator_stats(Add get_creator_stats view function #675) andget_pending_admin_action(Add get_pending_admin_action view function #677) were already implemented and meet their acceptance criteria as-is — no changes made for those.