test(idempotency): cover Redis lock guarantees for POST/PUT replay - #1240
Merged
ayomideadeniran merged 1 commit intoAug 31, 2026
Merged
Conversation
Add a unit suite for the idempotency middleware verifying the RFC-compatible behaviour required for financial/certificate-minting endpoints: pass-through without a key, cached-response replay for an identical key within the TTL, 409 conflict while a concurrent request holds the lock, atomic lock release on completion, and 400 for malformed oversized keys. Closes StellarDevHub#1126
|
@aurorabini is attempting to deploy a commit to the Ayomide Adeniran's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@aurorabini Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive unit coverage proving the idempotency middleware enforces the Redis lock guarantees required for financial and certificate-minting endpoints (issue #1126).
The middleware itself is already wired into
POST /certificates,POST /subscribe, webhook ingest, and enrollment routes; this PR locks in its guarantees with tests insrc/middleware/idempotency.test.ts:Idempotency-Keyheader is present.X-Idempotency-Replay: true, without re-executing the handler.All 5 tests pass (
npx vitest run src/middleware/idempotency.test.ts).Closes #1126