Fix/1365 settlement authorization validation - #1385
Merged
1nonlypiece merged 3 commits intoAug 30, 2026
Merged
1nonlypiece merged 3 commits into
1nonlypiece merged 3 commits into
Conversation
Add focused unit and integration coverage for outbox dispatching and snapshot workers, including success, failure, retry, boundary, and permission behavior.
Validate settlement route parameters, wallet identity, network, numeric values, ownership, and server responses before sensitive actions. Add regression coverage for replay, tampering, wrong-network, disconnected-wallet, malformed-response, retry, and authorization cases.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strengthens authorization and input validation for settlement receipts and transaction history before sensitive UI actions and API calls.
Changes
Validate commitment route parameters at the boundary
Validate wallet identity before sensitive operations
Validate the connected network
Validate numeric transaction and settlement values
Validate server responses before consuming settlement data
Enforce ownership and authorization checks instead of relying on client state
Added protection and regression coverage for:
Preserved existing successful settlement and transaction-history behavior
Validation
npm test npm run lint npm run typecheckFocused settlement tests were also executed where available.
Design Tradeoffs
Validation is performed at the boundary so malformed or unauthorized data is rejected before reaching sensitive settlement operations.
Client-side wallet state is treated as input rather than proof of ownership or authorization.
Limitations
Any pre-existing CI failures unrelated to settlement receipts or transaction history are documented and were not modified as part of this issue.
Acceptance Criteria
closes #1365