Fix/1379 client secret boundary - #1414
Open
Achievers-sketch wants to merge 11 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1379
Summary
Adds a dedicated unit test suite for
context/WalletContext.tsx, covering the provider's full state machine: connect/disconnect transitions, network state resolution, session persistence rehydration, consumer re-renders, and the hook guard.Changes
New Files
context/WalletContext.test.tsx— 23 test cases organized into 7describeblockscontext/WALLET_CONTEXT_TESTS.md— Test plan documentation for reviewersModified Files
vitest.config.ts— Addedcontext/**/*.test.{ts,tsx}to theaccessibilityproject's include patterns so the new test file is discovered byvitestTest Coverage
TESTNETfor testnet,PUBLICfor mainnet,PUBLICfor PUBLIC stringuseWalletContextthrows outsideWalletProviderVerification
All 23 tests pass deterministically. The suite uses DOM-based rendering with
data-testidattributes for state assertions and wraps async transitions inact()withwaitForpolling for stability.Edge Cases Covered
window.stellaris absent vs. when it returns invalid dataNEXT_PUBLIC_STELLAR_NETWORK(mainnet/PUBLIC)Notes
@testing-library/reactrender+actinstead ofrenderHookfor connect/disconnect interaction tests, as React 19's batching inrenderHookdoesn't reliably flush synchronous-throw state updates inside asyncactcallbackshooks/useWallet.test.tsxhas rotted (broken imports, stale error messages) and continues to fail independently — these are pre-existing issues unrelated to this PR