Skip to content

Ignore cmake-build-debug directory#3066

Merged
alex-w merged 2 commits into
Stellarium:masterfrom
Neniel:ignore-cmake-build-debug
Feb 21, 2023
Merged

Ignore cmake-build-debug directory#3066
alex-w merged 2 commits into
Stellarium:masterfrom
Neniel:ignore-cmake-build-debug

Conversation

@Neniel
Copy link
Copy Markdown
Contributor

@Neniel Neniel commented Feb 21, 2023

This change is for adding cmake-build-debug directory in the .gitignore file.

Description

This change is for adding cmake-build-debug directory in the .gitignore file. cmake-build-debug directory is generated automatically when opening the project with CLion.

Fixes # (issue)

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update

How Has This Been Tested?

Test Configuration:

  • Operating system: <Name, version number>
  • Graphics Card: <Manufacturer (likely Intel, NVidia, AMD?), Model (HD, Geforce, Radeon..., with model number), driver version?>

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@gzotti
Copy link
Copy Markdown
Member

gzotti commented Feb 21, 2023

Usually the build directory should be created outside the stellarium source directory. Is this unavoidable when using this CLion?

@alex-w
Copy link
Copy Markdown
Member

alex-w commented Feb 21, 2023

Probably cmake-build-release (common: cmake-build-*) need too, but this is coming from default settings of IDE. By default we expected some directories within builds directory

@alex-w alex-w added the infrastructure Infrastructure related issues label Feb 21, 2023
@Neniel
Copy link
Copy Markdown
Contributor Author

Neniel commented Feb 21, 2023

It has to do with the default configuration of the IDE:
image

I'm not sure if this has the same usage as the build directory that currently exists on the project (where builds have to be made)

@alex-w alex-w added this to the 23.1 milestone Feb 21, 2023
Copy link
Copy Markdown
Member

@gzotti gzotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems it does not hurt.

@alex-w alex-w merged commit 51e5d24 into Stellarium:master Feb 21, 2023
@github-actions
Copy link
Copy Markdown

Hello @Neniel!

The enhancement or feature has been merged into source code and you may test it via building Stellarium from source code or wait the weekly development snapshot...

@github-actions
Copy link
Copy Markdown

Hello @Neniel!

The fix has been merged into source code and you may test it via building Stellarium from source code or wait the weekly development snapshot...

@alex-w alex-w added state: published The fix has been published for testing in weekly binary package and removed state: fixed labels Mar 13, 2023
@github-actions
Copy link
Copy Markdown

Hello @Neniel!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Mar 27, 2023
@github-actions
Copy link
Copy Markdown

Hello @Neniel!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infrastructure Infrastructure related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants