Add parallax effect to stars#4023
Conversation
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
This is an automatically generated QA checklist based on modified files. |
1908f9f to
10d34e9
Compare
|
A real world check with Proxima Cen. NASA New Horizon's observation where the parallax computed here match what New Horizon has observed "near" Pluto in Apr 2020 (I emphasize "near" because it has passed Pluto in 2015 so long gone from Pluto in 2020 but it is the closest object I can select in Stellarium). Ref: https://www.nasa.gov/solar-system/nasas-new-horizons-conducts-the-first-interstellar-parallax-experiment/ This is the images NASA took, I have added a few anchors to help you navigate: |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
10d34e9 to
d038b29
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
The placement of the marker ring is off (should be simple to fix), but the result is impressive! |
Stars don't connect to the constellation lines either, perhaps the same reason. EDIT: Nevermind, I was using yesterday's build. |
|
Awesome feature! When multiplier is 1000 - I think it can be very impressive demo for real planetariums too |
|
This is fabulous. Watching Proxima Cen or Barnard's star with all effects (nutation, aberration, parallax) together with equatorial grid is a somewhat dizzying experience, showing the difficulties in actually measuring position. And greatly funny to see a two-color rendition of Barnard's star, Proxima, Wolf 359 or Groombridge 1830 in DSS - you can date the plates! Yes, at 1000x it reminds me of one special projector in Vienna's old Zeiss Model IV which had a wobbling Sirius to demonstrate parallax, probably at 1000x. Not many bright stars can be said to have notable parallax, though. |
|
Hmm, standing on another planet/moon and pressing "Return to default location" crashes the program for me. |
|
Uh, yes, selecting Jupiter and pressing GOTO (Ctrl-G) also crashes. IIRC the same call. |
e6013f6 to
31f8825
Compare
…rash (also caching Aberration)
…r wont be effective
…d, compare pointers instead of planet names
105b049 to
f067ac6
Compare
4a5c744 to
bf60c18
Compare
|
I've added barycentric position and velocity function for DE43* and DE44*, otherwise the Sun is assumed to be at the barycenter of the solar system. I've switched parallax and aberration to use barycentric position and velocity. I think a high aberration will also mess up the "zoning" of stars but outside the scope of this PR. @alex-w @gzotti @10110111 this PR is ready to be reviewed |
|
Please rebase this against the current |
b321415 to
bf60c18
Compare
|
Selecting Mars and pressing Ctrl-G for "goto" still crashes :-( |
Yes, I can confirm crash when parallax is enabled only |
|
I think the root cause is planet to planet transition, now I have set to use cached parallaxdiff until the transition is completed. Seems to have fixed the problem. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Oops… @henrysky please resolve conflict |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
Hello @henrysky! Please check the fresh version (development snapshot) of Stellarium: |
|
Hello @henrysky! Please check the latest stable version of Stellarium: |



As discussed in #3982, this PR will add support for modelling parallax effect caused by the difference between the Earth's heliocentric location at the star catalog epoch and the current observer's location. Meaning the parallax effect here should be correctly modelled on different planets/moons too. This PR depends on the work of PR #3992 to be merged first which is work-in-progress, I am opening this PR now to show a work-in-progress preview.
This PR also adds support to update parallax of stars displayed in info string when on different planet/moon.Fixes # (issue)
Screenshots (if appropriate):
I have added an option to enable/disable Parallax effect, and to exaggerate parallax effect from 1x to 10000x.
<img width="823" alt="Screenshot 2024-12-24 at 1 38 04 AM" src="https://github.com/user-attachments/assets/f99c0cdb-a288-4097-aeda-bdd945df5730" />To sanity check for now, you can stay on Earth or go to a different planet, enable parallax but disable aberration (so only parallax effect is shown), display ecliptic plane line. Stars near the ecliptic plane should move in 1d motion parallel to the ecliptic plane while stars farthest from the ecliptic plane should move in circular motion. The period of the motion of stars should match the orbital period of the planet. Keeping the same exaggeration factor, stars should have greater motion caused by parallax when you are on an outer planet like Uranus.
Here are video showing the parallax effect:
On earth near ecliptic plane (exaggerate 1000x):
1.mov
On earth near ecliptic pole (exaggerate 1000x):
2.mov
On Uranus near ecliptic plane (exaggerate 1000x):
3.mov
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: