Check for star null pointer when loading constellation data#4207
Merged
Conversation
… the major star catalog corrupted/missing
|
Great PR! Please pay attention to the following items before merging: Files matching
This is an automatically generated QA checklist based on modified files. |
|
Hello @henrysky! Please check the fresh version (development snapshot) of Stellarium: |
|
Hello @henrysky! Please check the latest stable version of Stellarium: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check for star null pointer when loading constellation data in case one of the major star catalog corrupted/missing, or constellation data points to HIP stars that do not exist (e.g., HIP 119000). Currently, stellarium will crash on startup when for example level 1 catalog is missing. With this PR no star catalog is needed to launch Stellarium (i.e., even level 0-3 are missing).
Another minor tweaks in this PR is search for other designations beside HIP when loading exoplanet data.
Fixes # (issue)
Screenshots (if appropriate):
Type of change
How Has This Been Tested?
Test Configuration:
Checklist: