Skip to content

Check for star null pointer when loading constellation data#4207

Merged
alex-w merged 1 commit into
Stellarium:masterfrom
henrysky:starcat_crash
Mar 14, 2025
Merged

Check for star null pointer when loading constellation data#4207
alex-w merged 1 commit into
Stellarium:masterfrom
henrysky:starcat_crash

Conversation

@henrysky
Copy link
Copy Markdown
Contributor

Check for star null pointer when loading constellation data in case one of the major star catalog corrupted/missing, or constellation data points to HIP stars that do not exist (e.g., HIP 119000). Currently, stellarium will crash on startup when for example level 1 catalog is missing. With this PR no star catalog is needed to launch Stellarium (i.e., even level 0-3 are missing).

Another minor tweaks in this PR is search for other designations beside HIP when loading exoplanet data.

Fixes # (issue)

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Test Configuration:

  • Operating system: MacOS 15
  • Graphics Card: Apple M3

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions
Copy link
Copy Markdown

Great PR! Please pay attention to the following items before merging:

Files matching src/**/*.cpp:

  • Are possibly unused includes removed?

This is an automatically generated QA checklist based on modified files.

Copy link
Copy Markdown
Member

@alex-w alex-w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@alex-w alex-w added this to the 25.1 milestone Mar 14, 2025
@alex-w alex-w merged commit d973f80 into Stellarium:master Mar 14, 2025
@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Mar 17, 2025
@github-actions
Copy link
Copy Markdown

Hello @henrysky!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Mar 23, 2025
@github-actions
Copy link
Copy Markdown

Hello @henrysky!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants