Skip to content

Added Potawatomi skyculture#4869

Open
retroj wants to merge 3 commits into
Stellarium:masterfrom
retroj:master
Open

Added Potawatomi skyculture#4869
retroj wants to merge 3 commits into
Stellarium:masterfrom
retroj:master

Conversation

@retroj
Copy link
Copy Markdown

@retroj retroj commented Apr 11, 2026

This adds a Potawatomi skyculture, developed by the Neshnabé Nengosêk Kenomagéwen (Potawatomi Star Knowledge) Project.

Description

Fixes # (issue)

Screenshots (if appropriate):

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

This skyculture has been developed and tested in Stellarium 25.2.

Test Configuration:

  • Operating system: Windows 10
  • Graphics Card: <Manufacturer (likely Intel, NVidia, AMD?), Model (HD, Geforce, Radeon..., with model number), driver version?>

Checklist:

The patch contains only a skyculture, no code changes.

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 11, 2026

Great PR! Please pay attention to the following items before merging:

Files matching skycultures/**:

  • Did you remember to update skycultures/CMakeLists.txt file respectively to changes in sky cultures?
  • Did you remember to define classification parameter in sky cultures (see index.json file)?
  • Did you remember to define license parameter in sky cultures (see description.md file)?
  • Did you remember to define region parameter in sky culture (see index.json file)?

This is an automatically generated QA checklist based on modified files.

@gzotti gzotti added this to the 26.2 milestone Apr 11, 2026
@gzotti
Copy link
Copy Markdown
Member

gzotti commented Apr 11, 2026

Thanks! As said before in PM, please in addition to the automated guidelines above,

  • Note that V26.1 has introduced a map function with which you should provide the geolocation of your people (a simple GeoJSON file with one or a few polygons). All details about the skyculture formatting is provided in the latest (V26.1) User Guide, chapter 9.
  • We would especially welcome more context (stories) both about your people (life circumstances etc.) and mythology to bring "life" into the constellation figures, if that can be revealed to foreigners. Else it's just "dead/empty imagery" and most users move on quickly and won't engage. But your nice artwork deserves some attention!
  • Please be really sure about licensing. I see CC-BY-NC-SA which is pretty friendly. It is clear that nobody but you should sell T-shirts or coffee mugs with your artwork. A problem that has occurred in the past is the question whether a planetarium show is "commercial" (because selling tickets) or "educational" (because it should be). If there can be any reservations (by tribal elders etc.), please explicitly include or exclude use in public presentations when tickets of any price are involved. And:
  • as important as the license texts are to decide what users are allowed to do, they all (including the TK labels) should be moved towards the end of the description file.

@gzotti gzotti moved this from Backlog to In review in Skycultures 2.0 Apr 11, 2026
@alex-w
Copy link
Copy Markdown
Member

alex-w commented Apr 13, 2026

Thank you very much for new sky culture!

Is it possible to add an IPA data for constellations? What about using abbreviations as designations for constellations like Ursa Major -> UMa for standard constellations? What about stars and planets - these object doesn't have native names?

@alex-w alex-w added the subsystem: skycultures The issue is related to skycultures of planetarium... label Apr 13, 2026
@gzotti
Copy link
Copy Markdown
Member

gzotti commented Apr 13, 2026

Indeed, numerical abbreviations as ID are long deprecated and should be the exception, not the rule. The short names should help as mnemonic when displayed on screen.

@alex-w
Copy link
Copy Markdown
Member

alex-w commented May 6, 2026

@retroj any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

subsystem: skycultures The issue is related to skycultures of planetarium...

Projects

Status: In review

Development

Successfully merging this pull request may close these issues.

3 participants