Add support for CelesTrak CSV instead of TLE#4890
Conversation
63efc9c to
ce31930
Compare
|
So, this seems to work, except for the things I don't know how to check:
Also, parsing time seems to have increased, particularly due to the need to parse the Epoch field, which is now specified in the form like |
Please try press the button Add (Plus) in the GUI of Satellites plugin
This was a Celestrak's feature for TLE and apparently it removed now from other formats - probably this is time to drop support of it (including filters) :-/
Bad news :( The NORAD ID number is important data for satellite observers, but at least the COSPAR/NSSDC ID is here. Well, the search tool and infostrings should be updated too in this case. Plus apparently the TLE block in the plugin's GUI should be removed or, at least, hidden.
Please do it. |
I didn't mean that the NORAD id is no longer available: it is, it's just taken from the CSV What I did mean is that, since the TLE strings are available in |
|
Aha, OK, the new behavior is fine for me. Please check unit tests - some methods was added for UT |
|
Looks like CelesTrak is becoming more and more restrictive. Not only does it forbid downloading Starlink and Active GROUPs more than once in 2 hours (see the discussion at the bottom of this page), but it also has banned my IP address for two hours due to my repeated once in a few minutes updates of other groups from Stellarium for debugging:
In fact, they not only blocked me from access to the elements, but even to the docs on data formats and to the very discussion of the limits (see the first link above). |
|
So with the manual parsing of the CSV epoch parsing times went back to sensible: 21 s → 0.39 s (though in the future Satellites and Exoplanets should still move their parsing etc. to separate threads: GUI thread is not meant for this). |
This patch also simplifies the code by early returning and avoiding redundant file close/remove operations that will be done by the destructor anyway.
|
Hello @10110111! Please check the fresh version (development snapshot) of Stellarium: |
The 5-digit TLE field for NORAD id is going to be used up soon. This PR tries to implement the CelesTrak's CSV format that should be used for all downloads.
The current approach is to generate the TLE from the CSV entries, because it seems that too much code relies on this format. The NORAD ids in the generated output will be 0, and the actual id will be stored separately.
Currently the code is completely untested, I'm making a PR just to track the progress of this and possibly to discuss different approaches to the solution.