Skip to content

SCM: add common_names tab (#4657)#4912

Open
xLPMG wants to merge 4 commits into
Stellarium:masterfrom
xLPMG:scm-name-celestial-bodies
Open

SCM: add common_names tab (#4657)#4912
xLPMG wants to merge 4 commits into
Stellarium:masterfrom
xLPMG:scm-name-celestial-bodies

Conversation

@xLPMG
Copy link
Copy Markdown
Contributor

@xLPMG xLPMG commented May 11, 2026

This PR adds a "Common Names" tab to the sky culture editor, which lets the user insert cultural names of stars, plansts and DSOs

Fixes #4657

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • This change requires a documentation update
  • Housekeeping

How Has This Been Tested?

Created different sky cultures on my macbook.

Checklist:

  • My code follows the code style of this project.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (header file)
  • I have updated the respective chapter in the Stellarium User Guide
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@xLPMG
Copy link
Copy Markdown
Contributor Author

xLPMG commented May 11, 2026

I'm not 100% sure what the most intuitive workflow is. Currently possible:

  1. To create a new name: Fill data --> Press "Add Entry" -> repeat
  2. To edit a name: click in list on common name, then press "Load selected" to load data or simply fill from scratch -> Press "Save Entry" to override or "Add Entry" to add as a new name

@alex-w alex-w added this to the 26.2 milestone May 11, 2026
@alex-w alex-w added subsystem: plugins The issue is related to plugins of planetarium... subsystem: skycultures The issue is related to skycultures of planetarium... labels May 11, 2026
@xLPMG xLPMG marked this pull request as ready for review May 11, 2026 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

subsystem: plugins The issue is related to plugins of planetarium... subsystem: skycultures The issue is related to skycultures of planetarium...

Projects

Status: Backlog
Status: Backlog

Development

Successfully merging this pull request may close these issues.

The SCM plugin should add the functionality of naming celestial bodies

2 participants