Skip to content

Add option to force full cloning of VMs#48

Merged
LukasK32 merged 2 commits into
mainfrom
full-clones
Jul 24, 2025
Merged

Add option to force full cloning of VMs#48
LukasK32 merged 2 commits into
mainfrom
full-clones

Conversation

@keyaray

@keyaray keyaray commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

Description

This change allows to force the full clone of template machine.

How Has This Been Tested?

Manually. I ran it on my cluster.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@keyaray keyaray self-assigned this Jul 23, 2025
@keyaray keyaray added the enhancement New feature or request label Jul 23, 2025
@keyaray keyaray requested a review from LukasK32 July 23, 2025 11:47

@LukasK32 LukasK32 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly stylistic changes, I tested it and it works 👍

Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread pkg/pve-node-driver/l10n/en-us.yaml Outdated
Comment thread pkg/pve-node-driver/machine-config/pve.vue Outdated
keyaray added 2 commits July 24, 2025 09:34
… machine

Signed-off-by: Kacper Szymański <kacper@stellatarum.com>
…ed section

Signed-off-by: Kacper Szymański <kacper@stellatarum.com>
@keyaray keyaray requested a review from LukasK32 July 24, 2025 09:37
@LukasK32 LukasK32 added docker-machine-driver Related to the docker-machine driver rancher-ui-extension Related to the Rancher UI Extension labels Jul 24, 2025

@LukasK32 LukasK32 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LukasK32 LukasK32 merged commit 92f5f38 into main Jul 24, 2025
7 checks passed
@LukasK32 LukasK32 deleted the full-clones branch July 24, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docker-machine-driver Related to the docker-machine driver enhancement New feature or request rancher-ui-extension Related to the Rancher UI Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants