Skip to content
This repository was archived by the owner on Feb 16, 2023. It is now read-only.

Conversation

@Ruslan-Aleev
Copy link

@Ruslan-Aleev Ruslan-Aleev commented Aug 31, 2020

Fixed incorrect triggering of the condition:

  • Removed the mistaken negation (why do we need the $reserved array at all?)
  • Added accounting for encoding in calculating length

Also changed minChars according to the documentation (it says 3, not 4) - https://docs.modx.com/current/en/extras/simplesearch/simplesearch

Related issue https://github.com/Sterc/SimpleSearch/issues/41

@Ruslan-Aleev
Copy link
Author

@sepiariver @Jako When you have time, check this PR, please.

@Jako
Copy link
Contributor

Jako commented Nov 14, 2020

Maybe someone at Sterc (@MrRoco, @sdrenth) could look into this. The issue should be valid.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants