nix flake: use lib.mkAfter put the host list at the end
#2814
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toastal
force-pushed
the
nix-mkafter
branch
2 times, most recently
from
db1d052 to
dd05205
Compare
toastal
force-pushed
the
nix-mkafter
branch
2 times, most recently
from
8888ec1 to
b2d5175
Compare
toastal
changed the title
lib.mkAfter to allow extraHostslib.mkAfter put the host list at the end
toastal
force-pushed
the
nix-mkafter
branch
2 times, most recently
from
dbb555e to
2e56bfe
Compare
At present, if a user uses ``networking.stevenBlockHosts.enable = true``
in tandem with ``networking.extraHosts``, the ``extraHosts`` will put be
put after which makes it very difficult to see the custom adds with even
the ``$PAGER`` operating a bit slow due to file size. I would propose
putting this project’s hosts at the end of the hosts file. Meaning:
.. code:: nix
{
networking = {
stevenBlockHosts.enable = true;
extraHosts = ''
127.0.0.1 myproject.localhost
'';
};
}
will now output
.. code::
127.0.0.1 localhost
::1 localhost
127.0.0.1 myproject.localhost
# Title: StevenBlack/hosts with the fakenews extension
#
# …
Format: text/x-rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, if a user uses
networking.stevenBlockHosts.enable = truein tandem withnetworking.extraHosts, theextraHostswill put be put after which makes it very difficult to see the custom adds with even the$PAGERoperating a bit slow due to file size. I would propose putting this project’s hosts at the end of the hosts file. Meaning:will now output
NOTE: using
lib.*like #2813 to avoid a potential merge conflictAlso has been open @ https://gitlab.com/StevenBlack/hosts/-/merge_requests/3