decrease power of jump if user clicks fast enough #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…withing 20 frames of the previous click
dyc3
requested changes
Nov 18, 2022
src/models/player.py
Outdated
Comment on lines
43
to
54
| # set the jump timer to 0 if negative so number doesn't underflow after a long time | ||
| # self.jump_timer = max(self.jump_timer - frame_diff, 0) | ||
| # if self.jump_timer > 0: | ||
| # # print(self.jump_timer) | ||
| # self.jump_timer -= 1 | ||
| # return | ||
| # else: | ||
| # # print(self.jump_timer) | ||
| # # (n = 20) frames | ||
| # self.jump_timer = 20 | ||
| # self.y_velo = self.jump_power | ||
| # return |
There was a problem hiding this comment.
nit: remove commented code, or uncomment it
|
How does the decreasing jumping power affect the feeling of the gameplay? I don't like it and would rather keep the old system. Or we could continue tweaking the numbers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it sets the jump power to 95% of what it was if the user clicks within 20 frames.
Otherwise it resets the jump power to normal_jump_power
I left my old 20 frame jump prevention system so its easy to switch back to if we don't like this new method.
Honestly, I don't really like it. Maybe the numbers need to be tweaked, but it doesn't feel right.
Issue #19