Skip to content

Fix: ensure impulse response returns at least one bin when width < dt… #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: ensure impulse response returns at least one bin when width < dt… #914

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions stingray/simulator/simulator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from stingray import utils
from stingray import Lightcurve
from stingray import AveragedPowerspectrum
import math

__all__ = ["Simulator"]

Expand Down Expand Up @@ -275,10 +276,10 @@ def simple_ir(self, start=0, width=1000, intensity=1):
"""

# Fill in 0 entries until the start time
h_zeros = np.zeros(int(start / self.dt))
h_zeros = np.zeros(math.ceil(start / self.dt))

# Define constant impulse response
h_ones = np.ones(int(width / self.dt)) * intensity
h_ones = np.ones(math.ceil(width / self.dt)) * intensity

return np.append(h_zeros, h_ones)

Expand Down