Refactor argument handling: simplify logic by using arg_len variable #915
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteobachetti
requested changes
Jun 25, 2025
There was a problem hiding this comment.
Thanks @kaz2700 !
I made a couple of minor suggestions, otherwise the code looks good.
You will need to add a changelog in towncrier format, as specified in the developer instructions , and make sure the formatting is right, by running black on the code, as described in the formatting guide
| elif len(args) == 2: | ||
| elif arg_len == 2: | ||
| if utils.is_string(args[0]): | ||
| return self._simulate_model_string(args[0], args[1]) |
There was a problem hiding this comment.
Suggested change
| return self._simulate_model_string(args[0], args[1]) | |
| return self._simulate_model_string(*args) |
| elif arg_len == 2: | ||
| if utils.is_string(args[0]): | ||
| return self._simulate_model_string(args[0], args[1]) | ||
|
|
||
| return self._simulate_impulse_response(args[0], args[1]) |
There was a problem hiding this comment.
Suggested change
| return self._simulate_impulse_response(args[0], args[1]) | |
| return self._simulate_impulse_response(*args) |
| return self._simulate_impulse_response(args[0], args[1]) | ||
|
|
||
| elif len(args) == 3: | ||
| elif arg_len == 3: | ||
| return self._simulate_impulse_response(args[0], args[1], args[2]) |
There was a problem hiding this comment.
Suggested change
| return self._simulate_impulse_response(args[0], args[1], args[2]) | |
| return self._simulate_impulse_response(*args) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide an overview of the implemented solution or the fix and elaborate on the modifications.
Refactored the argument handling logic in the simulation code. Introduced a variable
arg_lento simplify the checks on the length ofargsand reduce redundancy. The new structure first checks the length ofargsand branches accordingly to call the appropriate simulation methods (_simulate_power_law,_simulate_model,_simulate_model_string,_simulate_power_spectrum, or_simulate_impulse_response) based on the type and number of arguments passed.Is there a new dependency introduced by your contribution? If so, please specify.
No new dependencies have been introduced.
Any other comments?
This refactor improves the readability and maintainability of the code.