Skip to content

Improve stingray.simulator docs #920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Improve stingray.simulator docs #920

wants to merge 6 commits into from

Conversation

Sauravroy34
Copy link
Contributor

Fixed for TODO

@Sauravroy34 Sauravroy34 changed the title Fix todo docs improvement Improve stingray.simulator docs Apr 14, 2025
@matteobachetti
Copy link
Member

Hi @Sauravroy34 , thanks for the PR, I like how you documented the function. Please run black on the code so that the test passes, it's almost certainly because of a line longer than 100 characters.

matteobachetti
matteobachetti requested changes Apr 22, 2025
View reviewed changes
Copy link
Member

@matteobachetti matteobachetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small thing: the black test should pass.

@Sauravroy34
Copy link
Contributor Author

Hi @Sauravroy34 , thanks for the PR, I like how you documented the function. Please run black on the code so that the test passes, it's almost certainly because of a line longer than 100 characters.

sure , I forgot about that one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteobachetti matteobachetti matteobachetti requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
no-changelog-entry-needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sauravroy34 @matteobachetti