Pipeline shows disabled endpoints fix (#2881) #3282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the dropdown menu in the pipeline configuration displayed all endpoints, including disabled ones, and allowed API calls to them. Fixes: Updated EndpointInterceptor to correctly parse request URIs and match them to corresponding endpoint names in settings.yml, ensuring disabled endpoints are blocked. Added a new API endpoint in SettingsController to expose the endpointStatus map, allowing the frontend to check which endpoints are disabled. Updated pipeline.js to use this new API and hide disabled endpoints from the dropdown menu. Tests: Created a new Docker Compose setup using a custom settings.yml where all endpoints are disabled. Implemented a test script to run this setup, send API requests to disabled endpoints, and verify they are correctly blocked.
AndreSantos04
requested review from
Frooodle,
reecebrowne,
Ludy87,
DarioGii and
ConnorYoh
as code owners
dosubot
bot
added
size:XL
github-actions
bot
added
Java
DarioGii
previously approved these changes
Apr 2, 2025
|
|
Frooodle
approved these changes
Apr 2, 2025
Frooodle
approved these changes
Apr 2, 2025
DarioGii
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Previously, the dropdown menu in the pipeline configuration displayed all endpoints, including disabled ones, and allowed API calls to them.
Changes:
Updated EndpointInterceptor to correctly parse request URIs and match them to corresponding endpoint names in settings.yml, ensuring disabled endpoints are blocked.
Added a new API endpoint in SettingsController to expose the endpointStatus map, allowing the frontend to check which endpoints are disabled.
Updated pipeline.js to use this new API and hide disabled endpoints from the dropdown menu.
Tests:
Created a new Docker Compose setup using a custom settings.yml where all endpoints are disabled.
Implemented a test script to run this setup, send API requests to disabled endpoints, and verify they are correctly blocked.
Bug Fix Video
Closes #2881
Checklist
General
Documentation
UI Changes (if applicable)
Testing (if applicable)