Move Analytics Pixel from HTML <head> to Dynamic JavaScript Injection via Backend
#3293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ludy87
requested review from
Frooodle,
reecebrowne,
DarioGii and
ConnorYoh
as code owners
dosubot
bot
added
the
size:S
There was a problem hiding this comment.
Pull Request Overview
This PR moves the analytics pixel injection from a static HTML element in common.html to a dynamic JavaScript snippet generated by the backend via AdditionalLanguageJsController.java.
- Removed hardcoded static pixel from the HTML head.
- Dynamically injects the tracking pixel with JavaScript in AdditionalLanguageJsController.java.
Files not reviewed (1)
- src/main/resources/templates/fragments/common.html: Language not supported
Comments suppressed due to low confidence (1)
src/main/java/stirling/software/SPDF/controller/api/AdditionalLanguageJsController.java:59
- [nitpick] Consider renaming 'pixel' to 'trackingPixel' for improved clarity about its purpose.
const pixel = document.createElement('img');
github-actions
bot
added
Java
dosubot
bot
added
size:M
|
Hi @Ludy87. Could you explain why using dynamic js injection here is better than keeping the pixel in the front end? |
Because the generated JS is loaded in every situation. Feel free to suggest another option; I'm open to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Please provide a summary of the changes, including:
What was changed:
AdditionalLanguageJsController.javatoAdditionalJsController.javato better reflect its broader purpose./js/additional.js, replacing the previous/js/additionalLanguageCode.js.<head>incommon.htmlto the dynamically generated JavaScript response.Why the change was made:
<head>and instead move toward dynamic inclusion.Checklist
General
Documentation
UI Changes (if applicable)
Testing (if applicable)