Skip to content

hide cookie banner when analytics pop up shown #3403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

muratcanyeldan
Copy link
Contributor

@muratcanyeldan muratcanyeldan commented Apr 23, 2025

Before :

image

After :

Screenshot 2025-04-23 at 12 22 29

Closes #3372


Checklist

General

Documentation

UI Changes (if applicable)

  • Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

  • I have tested my changes locally. Refer to the Testing Guide for more details.

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Apr 23, 2025
@github-actions github-actions bot added the Front End Issues or pull requests related to front-end development label Apr 23, 2025
@muratcanyeldan muratcanyeldan marked this pull request as draft April 23, 2025 09:08
@muratcanyeldan muratcanyeldan marked this pull request as ready for review April 23, 2025 09:25
@Frooodle
Copy link
Member

Frooodle commented Apr 23, 2025

@muratcanyeldan We need to have the processing of the cookie consent accept/reject happen based on the users input in the other window
Not just only hide/show the banner itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Front End Issues or pull requests related to front-end development size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Hide Stirling PDF banners when on local install
2 participants