Skip to content

Comments

ci: add matrix strategy for spring-security and improve test report check logic#3768

Merged
Frooodle merged 7 commits intoStirling-Tools:mainfrom
Ludy87:build_dir_20250618
Jun 19, 2025
Merged

ci: add matrix strategy for spring-security and improve test report check logic#3768
Frooodle merged 7 commits intoStirling-Tools:mainfrom
Ludy87:build_dir_20250618

Conversation

@Ludy87
Copy link
Collaborator

@Ludy87 Ludy87 commented Jun 18, 2025

Description of Changes

  • Introduced a new matrix axis spring-security in the GitHub Actions workflow to run tests with and without Spring Security features enabled.
  • Removed duplicated build steps and unified them into a single Gradle task using the matrix value.
  • Refactored the test report check step to dynamically iterate over expected directories using a Bash array, improving maintainability and readability.
  • Ensured test report artifacts are uploaded regardless of test success, with clearer naming and a fallback if files are missing.

Checklist

General

Documentation

UI Changes (if applicable)

  • Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

  • I have tested my changes locally. Refer to the Testing Guide for more details.

Copilot AI review requested due to automatic review settings June 18, 2025 20:47
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines ignoring generated files. label Jun 18, 2025
@github-actions github-actions bot added Docker Pull requests that update Docker code Github labels Jun 18, 2025
@dosubot dosubot bot added the enhancement New feature or request label Jun 18, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the CI workflow to capture additional test report outputs from the root project alongside the existing module directories.

  • Adds checks for the root build/reports/tests/ and build/test-results/ directories before reporting.
  • Extends the artifact upload step to include root-level test reports and problems outputs.
  • Ensures multi-module Gradle builds preserve comprehensive test outputs in CI artifacts.
Comments suppressed due to low confidence (3)

.github/workflows/build.yml:99

  • [nitpick] Consider adding a corresponding existence check for the root build/reports/problems/ directory in the missing_reports array to maintain consistency with the newly uploaded artifacts.
            build/reports/problems/

.github/workflows/build.yml:102

  • [nitpick] You may want to include a check for the module's build/reports/problems/ directory in the missing_reports section to avoid missing artifacts silently.
            stirling-pdf/build/reports/problems/

.github/workflows/build.yml:57

  • [nitpick] Consider using a glob pattern (e.g., /build/test-results/) to dynamically detect and upload all test report directories across modules instead of hardcoding each path.
          if [ ! -d "build/reports/tests/" ]; then

@dosubot dosubot bot added size:S This PR changes 10-29 lines ignoring generated files. and removed size:XS This PR changes 0-9 lines ignoring generated files. labels Jun 18, 2025
@dosubot dosubot bot added size:XS This PR changes 0-9 lines ignoring generated files. and removed size:S This PR changes 10-29 lines ignoring generated files. labels Jun 18, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines ignoring generated files. and removed size:XS This PR changes 0-9 lines ignoring generated files. labels Jun 18, 2025
@Ludy87 Ludy87 changed the title ci: include additional test report paths in artifact upload and checks ci: add matrix strategy for spring-security and improve test report check logic Jun 18, 2025
@Frooodle Frooodle merged commit 5a8162f into Stirling-Tools:main Jun 19, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docker Pull requests that update Docker code enhancement New feature or request Github size:M This PR changes 30-99 lines ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants