ci: add matrix strategy for spring-security and improve test report check logic#3768
Merged
Frooodle merged 7 commits intoStirling-Tools:mainfrom Jun 19, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the CI workflow to capture additional test report outputs from the root project alongside the existing module directories.
- Adds checks for the root
build/reports/tests/andbuild/test-results/directories before reporting. - Extends the artifact upload step to include root-level test reports and problems outputs.
- Ensures multi-module Gradle builds preserve comprehensive test outputs in CI artifacts.
Comments suppressed due to low confidence (3)
.github/workflows/build.yml:99
- [nitpick] Consider adding a corresponding existence check for the root build/reports/problems/ directory in the missing_reports array to maintain consistency with the newly uploaded artifacts.
build/reports/problems/
.github/workflows/build.yml:102
- [nitpick] You may want to include a check for the module's build/reports/problems/ directory in the missing_reports section to avoid missing artifacts silently.
stirling-pdf/build/reports/problems/
.github/workflows/build.yml:57
- [nitpick] Consider using a glob pattern (e.g., /build/test-results/) to dynamically detect and upload all test report directories across modules instead of hardcoding each path.
if [ ! -d "build/reports/tests/" ]; then
DarioGii
approved these changes
Jun 19, 2025
Frooodle
approved these changes
Jun 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
spring-securityin the GitHub Actions workflow to run tests with and without Spring Security features enabled.Checklist
General
Documentation
UI Changes (if applicable)
Testing (if applicable)