Skip to content

Conversation

@Ludy87
Copy link
Collaborator

@Ludy87 Ludy87 commented Dec 31, 2025

Description of Changes

What was changed

  • Added a new TypeScript declaration file: frontend/src/core/types/googleDrivePicker.d.ts.
  • Extended the global Window interface to include:
    • window.gapi: typeof gapi
    • window.google: typeof google

Why the change was made

  • Fixes TypeScript compilation errors (TS2339) where window.gapi and window.google were used by googleDrivePickerService.ts, but were not declared on Window & typeof globalThis.
  • Ensures the Google Drive Picker integration can access the expected global objects with proper typings.

Checklist

General

Documentation

Translations (if applicable)

UI Changes (if applicable)

  • Screenshots or videos demonstrating the UI changes are attached (e.g., as comments or direct attachments in the PR)

Testing (if applicable)

  • I have tested my changes locally. Refer to the Testing Guide for more details.

Copilot AI review requested due to automatic review settings December 31, 2025 13:30
@dosubot dosubot bot added the size:S This PR changes 10-29 lines ignoring generated files. label Dec 31, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@dosubot dosubot bot added the Bugfix Pull requests that fix bugs label Dec 31, 2025
@Ludy87 Ludy87 added the Front End Issues or pull requests related to front-end development label Dec 31, 2025
@Ludy87 Ludy87 closed this Jan 7, 2026
@Ludy87 Ludy87 deleted the global_typings_GoogleDrivePicker_20251231 branch January 7, 2026 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix Pull requests that fix bugs Front End Issues or pull requests related to front-end development size:S This PR changes 10-29 lines ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants