Skip to content

Conversation

@HminiL
Copy link
Contributor

@HminiL HminiL commented Feb 17, 2025

💡 I resolved the following issues:

  • Implemented RocketMQ integration for asynchronous trade event handling
  • Added trade event producer and consumer for order matching system
  • Configured RocketMQ in Docker environment
  • Removed legacy messaging implementation



💡 Code has been added while handling the issue:

  • Added TradeEventProducer for publishing trade events asynchronously
  • Added TradePersistenceConsumer for handling trade events
  • Modify Docker configuration for RocketMQ (namesrv, broker)
  • Modify RocketMQ configuration in application.yml



💡 Follow-up tasks are needed:

  • Consider adding monitoring/dashboard for RocketMQ
  • Add error handling and retry mechanism for failed messages
  • Add Publishing event after code refactoring is done



💡 The following resources might be helpful:



✅ Self Checklist

  • [xI am submitting this PR to the correct branch according to our branching strategy. (Not to master/main)
  • My commit messages follow the convention.
  • The modified code does not generate any compiler/browser warnings/errors.
  • The modified code passes all existing tests.
  • I have reviewed whether test additions are necessary and added them if needed.
  • I have reviewed whether documentation updates are necessary and updated them if needed.

@HminiL HminiL linked an issue Feb 17, 2025 that may be closed by this pull request
@pjho4746
Copy link
Contributor

Producer/Consumer 구조가 깔끔하게 잘 작성된 것 같아요! 수고하셨습니다~!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feat] Store Trade Records in Database using RocketMQ Consumer

3 participants