This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Added local Repo Support #106
Open
+23
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iuliaturc
suggested changes
Nov 11, 2024
sage/chat.py
Outdated
| @@ -74,6 +73,7 @@ def main(): | |||
|
|
|||
| validator = sage_config.add_all_args(parser) | |||
| args = parser.parse_args() | |||
| print(args) | |||
There was a problem hiding this comment.
Nit: could you please remove the print statement?
| @@ -81,6 +81,11 @@ def add_repo_args(parser: ArgumentParser) -> Callable: | |||
| default="repos", | |||
| help="The local directory to store the repository", | |||
| ) | |||
| parser.add( | |||
| "--repo-mode", | |||
| default = "remote", | |||
There was a problem hiding this comment.
We should also define the possible values (e.g. choices=["local", "remote"])
sage/data_manager.py
Outdated
Comment on lines
258
to
274
| def from_args_localRepo(args: Dict): | ||
| """Creates a GitHubRepoManager from command-line arguments and clones the underlying repository.""" | ||
| repo_manager = GitHubRepoManager( | ||
| repo_id=args.repo_id, | ||
| commit_hash=args.commit_hash, | ||
| access_token=os.getenv("GITHUB_TOKEN"), | ||
| local_dir=args.local_dir, | ||
| inclusion_file=args.include, | ||
| exclusion_file=args.exclude, | ||
| ) | ||
| if not repo_manager.local_dir: | ||
| # Proceed if local_dir exists and is not empty | ||
| raise ValueError( | ||
| f"The given Directory is empty, please provide the correct local dir " | ||
| ) | ||
|
|
||
| return repo_manager |
There was a problem hiding this comment.
Instead of creating a new from_args_localRepo method (which introduces a lot of duplication with from_args), I would simply change the implementation of repo_manager.download() to only call git clone if the repository doesn't already exist locally.
|
I have made the required changes you mentioned, please have a look. @iuliaturc |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It enable users to chat with their Repo's instead of pulling them from Github.
To index now this is what the CLI command should look like:
and this is the chat command:
Fixes # (issue)
#103
Before submitting
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag members/contributors who
may be interested in your PR.