Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for Related Origins Requests from WebAuthn 3 working draft #62

Merged

Conversation

Stormheg
Copy link
Member

@Stormheg Stormheg commented Mar 9, 2025

Fixes #42

Verified to work on Chrome v133 on macOS and Safari v18.3 using Caddy to emulate two different domains. Firefox has not added support yet.

Relevant piece of the spec: https://www.w3.org/TR/webauthn-3/#sctn-related-origins

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.0%. Comparing base (3ad1e62) to head (7aed169).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files          13       13           
  Lines         720      748   +28     
  Branches       59       63    +4     
=======================================
+ Hits          720      748   +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Stormheg Stormheg force-pushed the feature/well-known-related-origins branch from 274e9ed to a35ebbe Compare March 9, 2025 11:54
@Stormheg Stormheg force-pushed the feature/well-known-related-origins branch from a35ebbe to 7aed169 Compare March 9, 2025 11:59
@Stormheg Stormheg merged commit bb8f102 into Stormbase:main Mar 9, 2025
11 checks passed
Stormheg added a commit to Stormheg/django-otp-webauthn that referenced this pull request Mar 9, 2025
@Stormheg Stormheg deleted the feature/well-known-related-origins branch March 9, 2025 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Investigate and implement support for 'Related Origin Requests'
1 participant