feat(container): update image ghcr.io/rommapp/romm to v4.9.2#1667
Conversation
There was a problem hiding this comment.
ghcr.io/rommapp/romm: 4.8.1 → 4.9.0
Verdict: Safe to merge
No breaking changes or deprecations in this release affect the current configuration in kubernetes/apps/default/romm/app/helmrelease.yaml. One item worth being aware of for the future:
New features worth adopting:
- Save sync engine (rommapp/romm#3137, default path via rommapp/romm#3386) — RomM can now sync save files across client devices (on-demand, watched-folder, or scheduled background sync). The "File Transfer mode" staging area (incoming/outgoing/conflicts per device, plus SSH keys for watched-folder mode) defaults to
SYNC_BASE_PATH=${ROMM_BASE_PATH}/sync→/romm/sync, which is not covered by any volume inhelmrelease.yaml— it would land on the container's ephemeral writable layer and be lost on pod restart. Not an issue today:ENABLE_SYNC_FOLDER_WATCHERdefaults tofalseand the feature needs a compatible client app (just released in 4.9.0). If save sync gets adopted later, consider adding a mount for/romm/syncto the existingdataPVC (alongside theresources/assetssubPath mounts) so in-flight saves/conflicts survive restarts. - Unauthenticated asset exposure fixed (rommapp/romm#3480) — 4.8.1's image served
/romm/assets(private save files, states, screenshots, avatars) through an unauthenticated nginx static symlink. 4.9.0 removes that symlink and routes avatars through the authenticated/api/raw/assetsendpoint instead. No config change needed, fixed automatically by this bump. - Libretro thumbnails (rommapp/romm#3252) — enabled by default, adds region-correct (PAL/EU, JP, etc.) box art matching during scans with no config required.
Checked but not applicable: the highlighted config.yml warning about scan.export_gamelist → scan.export.gamelist_xml doesn't affect this deployment, since persistence.config (custom config.yml) is commented out/unused in helmrelease.yaml — defaults apply.
Sources consulted:
f0dcf5b to
23ceba2
Compare
There was a problem hiding this comment.
ghcr.io/rommapp/romm: 4.8.1 → 4.9.1
Verdict: Safe to merge
This PR has been rebased since the prior review (which covered 4.8.1 → 4.9.0). The new target is 4.9.1, a pure patch release on top of 4.9.0. All 4.9.0 findings from the previous review still apply (save sync path note, unauthenticated asset exposure fix, libretro thumbnails).
What's new in 4.9.1 (incremental over 4.9.0):
- Library detection fix: Structure A scan results now correctly take priority over Structure B — no config impact
config.ymlserialization fix for folder-to-platform mappings — no impact sincepersistence.configis unused inhelmrelease.yamlbypass_autologinfix for 403 interceptor during initialization — no config impact- Security dep bump: tornado 6.5.5 → 6.5.6 (dependency-only, no API change)
- Frontend build tooling updates (esbuild, vite, etc.) — no runtime impact
No breaking changes. No repository changes needed.
Sources consulted:
23ceba2 to
75c89d6
Compare
There was a problem hiding this comment.
ghcr.io/rommapp/romm: 4.8.1 → 4.9.2
Verdict: Safe to merge
This PR was previously reviewed at 4.8.1 → 4.9.0 and again after a rebase at 4.8.1 → 4.9.1 (both approved). It has since been rebased again to target 4.9.2. This review covers only the new incremental delta, 4.9.1 → 4.9.2 — all prior findings (save-sync /romm/sync mount note, unauthenticated-asset fix, libretro thumbnails, config.yml warning not applicable) still stand and are not repeated here.
What's new in 4.9.2 (incremental over 4.9.1):
fix: Crash on startup when no library(rommapp/romm#3544) — bootstraps a default library structure when none is detected, preventing a startup crash. Pure bug fix, no config surface change.- Dependency bumps only, no behavioral/config changes exposed to
helmrelease.yaml:python-multipart0.0.22 → 0.0.31 (internal multipart-parsing hardening/perf fixes — header size limits, boundary length caps; no public API change)aiohttp3.13.4 → 3.14.1,tornado6.5.6 → 6.5.7 (internal transport deps)js-yaml4.1.1 → 4.2.0,markdown-it14.1.1 → 14.2.0,ws/engine.io-clientbumps (frontend build-time/runtime deps only)
No breaking changes or deprecations in this delta. Nothing here requires changes to kubernetes/apps/default/romm/app/helmrelease.yaml.
Sources consulted:
- https://github.com/rommapp/romm/releases/tag/4.9.2
- rommapp/romm@4.9.1...4.9.2
- rommapp/romm#3544
- https://github.com/Kludex/python-multipart/releases (0.0.22 → 0.0.31 range)
- Prior reviews on this PR: the 4.9.0 review and the subsequent 4.9.1 rebase review
75c89d6 to
c56aaf1
Compare
c56aaf1 to
6747e5f
Compare
|
you should tell you claude not to link to like a dozen PRs lmaoooo |
This PR contains the following updates:
4.8.1→4.9.2Release Notes
rommapp/romm (ghcr.io/rommapp/romm)
v4.9.2Compare Source
What's Changed
Full Changelog: rommapp/romm@4.9.1...4.9.2
v4.9.1Compare Source
What's Changed
Full Changelog: rommapp/romm@4.9.0...4.9.1
v4.9.0Compare Source
Highlights
Save sync engine
"Coming soon" no more! Third-party app developers will now be able to rely on RomM to keep save files in sync across devices and platforms. #3137
Devices (apps, handhelds, browsers) can choose to register themselves with the server, which uniquely identifies them with a token. The system tracks which device has the latest version of a save file, flags conflicts when two devices change the same save, and syncs in whichever way fits the device: on demand, via a watched folder, or through a scheduled background sync.
Play session tracking
Another one for the app developers: client devices submit batches of play sessions per device, recording when and how long games were played. Sessions track both the time window (start_time/end_time) and screen-on time (duration_ms), which may differ due to device suspension or back-grounding. #3155
Libretro thumbnails
The libretro thumbnail repository is now available as a first-class artwork source for region-correct box art (PAL/Europe, Japan, etc.). Matching is exact case-insensitive against the directory listing, so a ROM named "(Europe)" lands on the (Europe) artwork. The source is enabled by default, and you can set it's priority in your
config.ymlvia thescan.priority.artworklist. #3252Pegasus metadata export
You can now auto-export a Pegasus compatible
metadata.pegasus.txtfile, just like the existinggamelist.xmlexport. Enable it in yourconfig.ymlfile by settingscan.export.pegasusto true, and it should appear in each platform folder (alongside your ROMs). #3153Notable changes
Fixes
cusregion in default ScreenScraper fallback regions by @gantoine in #3273DISABLE_EMULATOR_JSto Console mode (disable Play + block direct player route) by @gantoine in #3373gamelist.xmlexport to use relative media paths for local exports by @gtronset in #3369<alternativeEmulator>tags during gamelist.xml import by @gantoine in #3421<folder>entries in gamelist.xml metadata import by @gantoine in #3422miximage_v2media type to explicitly select SS.fr mixrbv2 by @gantoine in #3446Other changes
rom_files(rom_id)to fix slow game listing on large ROM sets by @gantoine in #3259job.get_id()withjob.idfor rq >= 2.7.0 compatibility by @gantoine in #3320New Contributors
Full Changelog: rommapp/romm@4.8.1...4.9.0-beta.1
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.