Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: External stylesheet caching #350

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Conversation

Stranger6667
Copy link
Owner

@Stranger6667 Stranger6667 commented Mar 26, 2024

Resolves #314

  • Configure cache from Python, JS, Ruby, C & CLI
  • Consider enabling cache by default - it seems to be useful in general.

Copy link

codspeed-hq bot commented Mar 26, 2024

CodSpeed Performance Report

Merging #350 will not alter performance

Comparing dd/cache-stylesheets (b9d28c9) with master (ee538f2)

Summary

✅ 6 untouched benchmarks

@Stranger6667 Stranger6667 force-pushed the dd/cache-stylesheets branch 5 times, most recently from 9a61b9e to 70fd340 Compare March 26, 2024 12:08
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.32%. Comparing base (ee538f2) to head (b9d28c9).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #350      +/-   ##
==========================================
+ Coverage   85.04%   86.32%   +1.28%     
==========================================
  Files          18       18              
  Lines        1759     1814      +55     
==========================================
+ Hits         1496     1566      +70     
+ Misses        263      248      -15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Stranger6667 Stranger6667 force-pushed the dd/cache-stylesheets branch 7 times, most recently from 2609a6e to 483c4cd Compare March 29, 2024 15:37
@Stranger6667 Stranger6667 marked this pull request as ready for review March 29, 2024 16:12
@Stranger6667 Stranger6667 force-pushed the dd/cache-stylesheets branch 2 times, most recently from d8db8db to b9d28c9 Compare March 29, 2024 18:18
Ref: #314
Signed-off-by: Dmitry Dygalo <[email protected]>
@Stranger6667 Stranger6667 merged commit cc55213 into master Mar 29, 2024
63 checks passed
@Stranger6667 Stranger6667 deleted the dd/cache-stylesheets branch March 29, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to cache resolved stylesheets
1 participant