Fix multiselecting issue with section field

[AbdiTolesa]

I'm not really sure why we were intentionally disallowing section fields to be multiselected originally (.edit_field_type_divider) but the fix looks simple although I had to sweat 😓 for hours since tracing the logic wasn't straight forward as the tricky part was just the pointer events disabled with CSS. 😆

.frm-sortable-helper,
.frm-multiselect-key-is-down li.form-field:not(.edit_field_type_divider) {
	pointer-events: none;
}

Test steps

1. Add a few fields, and section field.
2. Hold shift to multiselect fields.
3. Select the first few fields.
4. Click the section heading.
5. Confirm that the section field is added to the group selection instead of deselecting fields selected and opening the section field settings.

[coderabbitai]

Walkthrough

The pull request introduces a comprehensive update to the frm_admin.css file, focusing on establishing a robust and consistent design system for the Formidable Forms plugin. The changes primarily involve adding numerous CSS variables that define a comprehensive color palette, typography scales, spacing, border radii, and shadow styles. These variables aim to standardize design tokens across the plugin's user interface, enabling more maintainable and consistent styling.

Changes

File	Change Summary
css/frm_admin.css	Added 60+ CSS variables covering color scales (grey, primary, error, success), sizing, typography, spacing, and shadow styles

Suggested Labels

action: needs qa, run tests

Possibly Related PRs

• Update Default Form Styling #1640: Updates to CSS styles for form elements, which aligns with the comprehensive styling modifications in the main PR

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 850097c and 7e45820.

📒 Files selected for processing (1)

• css/frm_admin.css (1 hunks)

🔇 Additional comments (1)

css/frm_admin.css (1)

9275-9275: Potential side effect with pointer-events: none
Disabling pointer events on “.frm-multiselect-key-is-down li.form-field” will prevent any clicks, hovers, or other interactions on those form fields while the class is active. If the goal is purely to avoid accidental interactions during multi-select mode, this is fine. Otherwise, confirm that disabling pointer events here won’t cause unexpected user experience issues.

Would you like me to perform a codebase scan to see where ".frm-multiselect-key-is-down" is toggled and confirm its usage patterns?

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[lauramekaj1]

@AbdiTolesa I tested this and verified that the issue is fixed. Thank you!

[truongwp]

This works great! Thanks @AbdiTolesa!

[Crabcyborg]

@AbdiTolesa This CSS condition is here intentionally.

Right now you can multi-select specific rows from a section.

Screen.Recording.2025-09-30.at.12.37.10.PM.mov

This update changes it so you multi-select the entire section, not just a row.

Screen.Recording.2025-09-30.at.12.38.33.PM.mov

This is bigger of a change then I intended when I made the issue.

Can we do something more dynamic? It may require more than a simple CSS change.

[Crabcyborg]

Sorry about the delay replying to this!

I don't think we should merge this as-is as it introduces a different multi-select issue with sections.

See #2186 (comment)

[AbdiTolesa]

@Crabcyborg I'm working on this and found another issue when you try selecting a row inside of a section but I don't see that in your video. All fields are selected when I attempt to do so. I can reproduce it in the QA too as in this video:

CleanShot.2025-10-01.at.15.06.25.mp4

QA form: https://qa.formidableforms.com/abdi/wp-admin/admin.php?page=formidable&frm_action=edit&id=113

I can try including a fix for this in the same update if you think we should.

[Crabcyborg]

@AbdiTolesa Yeah, I was seeing that as well when holding shift. The video I attached is when holding cmd/ctrl.

There are two versions of the multi-select. One for selecting multiple fields individually (cmd/ctrl) and one for selecting a range of fields (shift).

We might want to try to tackle the issues separately so the required changes don't get mixed up.

[AbdiTolesa]

We might want to try to tackle the issues separately so the required changes don't get mixed up.

@Crabcyborg Thank you, I just created a new issue to track that issue. https://github.com/Strategy11/formidable-pro/issues/6017

[AbdiTolesa]

Closing this PR in favor of #2521