Fix pro issue 6081 (Square fatal error when refunding with payments s…

square/helpers/FrmSquareLiteApiHelper.php

@@ -0,0 +1,35 @@
+<?php
+if ( ! defined( 'ABSPATH' ) ) {
+	die( 'You are not allowed to call this page directly.' );
+}
+
+/**
+ * This file exists for backward compatibility with the Payments Submodule.
+ * Without these functions the Authorize.Net add on will trigger fatal errors.
+ */
+class FrmSquareLiteApiHelper {
+
+	/**
+	 * The payments submodule calls this function.
+	 * This function exists so payments can be refunded when the Stripe add-on or Authorize.Net is active.
+	 *
+	 * @param int $payment_id
+	 *
+	 * @return bool
+	 */
+	public static function refund_payment( $payment_id ) {
+		return FrmSquareLiteConnectHelper::refund_payment( $payment_id );
+	}
+
+	/**
+	 * The payments submodule calls this function.
+	 * This function exists so subscriptions can be cancelled when the Stripe add-on or Authorize.Net is active.
+	 *
+	 * @param string $sub_id
+	 *
+	 * @return bool
+	 */
+	public static function cancel_subscription( $sub_id ) {
+		return FrmSquareLiteConnectHelper::cancel_subscription( $sub_id );
+	}
+}

square/helpers/FrmSquareLiteConnectHelper.php

@@ -589,10 +589,11 @@ public static function get_latest_error_from_square_api() {
 	/**
 	 * @param string $receipt_id
 	 *
-	 * @return false|object
+	 * @return bool
 	 */
 	public static function refund_payment( $receipt_id ) {
-		return self::post_with_authenticated_body( 'refund_payment', array( 'receipt_id' => $receipt_id ) );
+		$data = self::post_with_authenticated_body( 'refund_payment', array( 'receipt_id' => $receipt_id ) );
+		return is_object( $data );
 	}
 
 	/**
@@ -702,10 +703,10 @@ public static function get_subscription_id_for_payment( $payment_id ) {
 	/**
 	 * @param string $subscription_id
 	 *
-	 * @return false|object
+	 * @return bool
 	 */
 	public static function cancel_subscription( $subscription_id ) {
-		return self::post_with_authenticated_body( 'cancel_subscription', compact( 'subscription_id' ) );
+		return false !== self::post_with_authenticated_body( 'cancel_subscription', compact( 'subscription_id' ) );
 	}
 
 	public static function handle_disconnect() {