-
Notifications
You must be signed in to change notification settings - Fork 0
Rename all type names with "account injection" to use "credential fetcher" #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Macil, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request implements a significant terminology refactoring to improve the clarity and consistency of the Glue runtime's public-facing APIs. By standardizing the language from 'account injection' to 'credential fetcher' for relevant types and functions, the codebase becomes more intuitive and easier to understand for developers integrating with the system. This change aims to make the API more descriptive and user-friendly by aligning the terminology with its actual purpose of fetching credentials. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request primarily renames all instances of 'account injection' to 'credential fetcher' across the codebase for improved clarity and consistency. This includes updating interface names (e.g., CommonAccountInjectionOptions to CommonCredentialFetcherOptions), type definitions, function names (e.g., registerAccountInjection to registerCredentialFetcher), and internal data structures in backendTypes.ts, common.ts, runtimeSupport.ts, mod.ts, mod.test.ts, and all integration runtime files. Additionally, the README.md was updated to remove an outdated Deno installation section, clarify GitHub event descriptions, and provide a concrete example for Slack's onNewMessage while removing the 'Common Options' documentation. The deno.json file was also modified to move Deno test permissions from command-line arguments into a dedicated test configuration block.
Greptile OverviewGreptile SummaryThis PR completes the renaming of "account injection" terminology to "credential fetcher" across all type names, following up on PR #13. All user-facing TypeScript types, interfaces, and function names have been consistently renamed.
The renaming is complete and consistent. No functional changes were made - this is purely a terminology update to improve clarity. Confidence Score: 5/5
Important Files ChangedFile Analysis
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
13 files reviewed, no comments
Follow-up to #13. Removes all mentions of "account injections" from type names. Now the only the mentions of "account injections" are internal, in URLs and property names shared with the backend.
This change may be a breaking change for type-checking of existing glues. This change does not affect runtime behavior and won't break any already-deployed glues.