Skip to content

Conversation

@Macil
Copy link
Contributor

@Macil Macil commented Dec 8, 2025

Follow-up to #13. Removes all mentions of "account injections" from type names. Now the only the mentions of "account injections" are internal, in URLs and property names shared with the backend.

This change may be a breaking change for type-checking of existing glues. This change does not affect runtime behavior and won't break any already-deployed glues.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Macil, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request implements a significant terminology refactoring to improve the clarity and consistency of the Glue runtime's public-facing APIs. By standardizing the language from 'account injection' to 'credential fetcher' for relevant types and functions, the codebase becomes more intuitive and easier to understand for developers integrating with the system. This change aims to make the API more descriptive and user-friendly by aligning the terminology with its actual purpose of fetching credentials.

Highlights

  • Terminology Refactoring: All type names containing 'account injection' have been systematically renamed to 'credential fetcher' across the codebase. This change enhances clarity and consistency for external APIs, while the original term is retained for internal backend-shared properties.
  • API and Interface Updates: Key interfaces, types, and functions such as AccountInjectionBackendConfig, AccountInjectionRegistration, CommonAccountInjectionOptions, and registerAccountInjection have been updated to their CredentialFetcher counterparts to reflect the new terminology.
  • Documentation and Examples: The README.md has been updated to remove an outdated installation section, refine GitHub event descriptions, and provide a more current Slack message listening example. Outdated 'Common Options' documentation was also removed for brevity.
  • Deno Configuration Update: The deno.json file has been updated to explicitly define test permissions, moving from a shorthand flag to a structured configuration for better clarity and control over test execution environments.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request primarily renames all instances of 'account injection' to 'credential fetcher' across the codebase for improved clarity and consistency. This includes updating interface names (e.g., CommonAccountInjectionOptions to CommonCredentialFetcherOptions), type definitions, function names (e.g., registerAccountInjection to registerCredentialFetcher), and internal data structures in backendTypes.ts, common.ts, runtimeSupport.ts, mod.ts, mod.test.ts, and all integration runtime files. Additionally, the README.md was updated to remove an outdated Deno installation section, clarify GitHub event descriptions, and provide a concrete example for Slack's onNewMessage while removing the 'Common Options' documentation. The deno.json file was also modified to move Deno test permissions from command-line arguments into a dedicated test configuration block.

@greptile-apps
Copy link

greptile-apps bot commented Dec 8, 2025

Greptile Overview

Greptile Summary

This PR completes the renaming of "account injection" terminology to "credential fetcher" across all type names, following up on PR #13. All user-facing TypeScript types, interfaces, and function names have been consistently renamed.

  • Renamed all type interfaces from *AccountInjectionOptions to *CredentialFetcherOptions across all integrations (GitHub, Google, Slack, Streak, Resend, Debug)
  • Updated CommonAccountInjectionOptions to CommonCredentialFetcherOptions in common.ts
  • Renamed registerAccountInjection to registerCredentialFetcher in runtimeSupport.ts
  • Updated all Zod validators to match the new naming
  • Correctly preserved accountInjections as a property name in the Registrations interface and in API URLs for backend compatibility

The renaming is complete and consistent. No functional changes were made - this is purely a terminology update to improve clarity.

Confidence Score: 5/5

  • This PR is safe to merge with no risk
  • This is a pure refactoring PR that renames types and functions for better clarity without changing any logic or behavior. All renames are consistent across the codebase, tests pass, and backward compatibility with the backend API is maintained by preserving the accountInjections property name and URL paths.
  • No files require special attention

Important Files Changed

File Analysis

Filename Score Overview
backendTypes.ts 5/5 Renamed types from AccountInjection to CredentialFetcher throughout; property name accountInjections intentionally kept for backend compatibility
common.ts 5/5 Renamed CommonAccountInjectionOptions to CommonCredentialFetcherOptions with corresponding Zod schema
runtimeSupport.ts 5/5 Renamed function and types from AccountInjection to CredentialFetcher; API URL path still uses accountInjections for backend compatibility
mod.ts 5/5 Updated exported type names from AccountInjectionOptions to CredentialFetcherOptions across all integrations
integrations/github/runtime.ts 5/5 Renamed GithubAccountInjectionOptions to GithubCredentialFetcherOptions
integrations/google/runtime.ts 5/5 Renamed GoogleAccountInjectionOptions to GoogleCredentialFetcherOptions
integrations/slack/runtime.ts 5/5 Updated to use CommonCredentialFetcherOptions and registerCredentialFetcher
integrations/streak/runtime.ts 5/5 Renamed StreakAccountInjectionOptions to StreakCredentialFetcherOptions
integrations/resend/runtime.ts 5/5 Renamed ResendAccountInjectionOptions to ResendCredentialFetcherOptions
integrations/debug/runtime.ts 5/5 Renamed registerRawAccountInjection to registerRawCredentialFetcher

Copy link

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

13 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

@Macil Macil merged commit 161ab49 into master Dec 8, 2025
1 check passed
@Macil Macil deleted the chris/renames branch December 8, 2025 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants