fix: Enable ASS/SSA subtitle styling by default #924
+5
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes Stremio#910 - ASS/SSA subtitles styles were being ignored in newer versions. Changed the default value of ass_subtitles_styling from false to true to match v4.4 behavior where subtitle styles (fonts, colors, positioning) were correctly preserved. Changes: - Set ass_subtitles_styling default to true in Settings - Updated migration v21 to set assSubtitlesStyling to true - Updated related test expectations
There was a problem hiding this comment.
Pull request overview
This PR restores ASS/SSA subtitle styling behavior to match v4.4 by enabling styling by default and ensuring existing profiles are migrated accordingly.
Changes:
- Set
ass_subtitles_stylingdefault totrueinSettingsand aligned serde default token expectations. - Updated
settings_deandDefaultTokensunit tests to expectassSubtitlesStyling: truefor default settings. - Adjusted the v21 storage migration to insert
"assSubtitlesStyling": truefor existing profiles and updated the corresponding migration test.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/unit_tests/serde/settings.rs |
Updates deserialization tests so Settings::default() now serializes/deserializes with assSubtitlesStyling set to true. |
src/unit_tests/serde/default_tokens_ext.rs |
Adjusts the default tokens for Settings so the generated default JSON includes assSubtitlesStyling: true. |
src/types/profile/settings.rs |
Changes the Default implementation for Settings to set ass_subtitles_styling to true. |
src/runtime/env.rs |
Modifies v21 migration to backfill assSubtitlesStyling as true and updates the migration test expectation accordingly. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #910 - ASS/SSA subtitles styles were being ignored in newer versions.
Changed the default value of ass_subtitles_styling from false to true to match v4.4 behavior where subtitle styles (fonts, colors, positioning) were correctly preserved.
Changes:
Testing: