Skip to content

Emit ended only on eof end-file reason#150

Merged
kKaskak merged 1 commit into
masterfrom
fix/shell-ended-only-on-eof
Jun 15, 2026
Merged

Emit ended only on eof end-file reason#150
kKaskak merged 1 commit into
masterfrom
fix/shell-ended-only-on-eof

Conversation

@kKaskak

@kKaskak kKaskak commented Jun 10, 2026

Copy link
Copy Markdown
Member

ShellVideo emitted ended for every mpv end-file event, including the stop caused by loading the next video, which made the player skip episodes when binge watching. Only emit ended for eof. Older shells report "other" for all non-error reasons so they keep the current behavior.

@kKaskak kKaskak self-assigned this Jun 10, 2026
@kKaskak
kKaskak requested a review from Botsy June 10, 2026 10:22
@kKaskak kKaskak added the bug Something isn't working label Jun 10, 2026
@kKaskak kKaskak added this to the v0.0.80 milestone Jun 10, 2026
@kKaskak
kKaskak merged commit 17a8383 into master Jun 15, 2026
1 check passed
@kKaskak
kKaskak deleted the fix/shell-ended-only-on-eof branch June 15, 2026 05:14
@kKaskak

kKaskak commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

regression found: EOF was emitted sometimes because of network disconnect etc
workaround in #151

correct implementation needs correct retry on http errors coming from addons
via ffmpeg http protocol docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working regression

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants