Skip to content

fix: recover shell early eof #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kKaskak merged 1 commit into from
Jun 23, 2026
Merged

fix: recover shell early eof #151

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@stremio/stremio-video",
"version": "0.0.81",
"version": "0.0.82",
"description": "Abstraction layer on top of different media players",
"author": "Smart Code OOD",
"main": "src/index.js",
Expand Down
14 changes: 13 additions & 1 deletion src/ShellVideo/ShellVideo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ var deepFreeze = require('deep-freeze');
var ERROR = require('../error');

var SUBS_SCALE_FACTOR = 0.0066;
var EOF_END_TOLERANCE = 60000;

var stremioToMPVProps = {
'loaded': 'loaded',
Expand Down Expand Up @@ -259,7 +260,9 @@ function ShellVideo(options) {
ipc.on('mpv-event-ended', function(args) {
// older shells report 'other' for every non-error reason, including eof
if (args.error) onError(args.error);
else if (!args.reason || args.reason === 'eof' || args.reason === 'other') onEnded();
else if (!args.reason || args.reason === 'eof' || args.reason === 'other') {
if (!isKnownEarlyEof()) onEnded();
}
});

function getProp(propName) {
Expand All @@ -279,6 +282,15 @@ function ShellVideo(options) {
function onEnded() {
events.emit('ended');
}
function isKnownEarlyEof() {
var time = props['time-pos'];
var duration = props.duration;
return typeof time === 'number' &&
isFinite(time) &&
typeof duration === 'number' &&
isFinite(duration) &&
time + EOF_END_TOLERANCE < duration;
}
function onPropChanged(propName) {
if (observedProps[propName]) {
events.emit('propChanged', propName, getProp(propName));
Expand Down