-
Notifications
You must be signed in to change notification settings - Fork 2
feat(2.0): add Velocity as a platform #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jan 5, 2026
Closed
A lot happened here, but the biggest change by far is the separation away from the horrible compiler API, which was causing me problems and headaches and abstracting it away into my own (rather big) abstraction, providing everything that I need. This has a few advantages, including (but not limited to): 1. I can finally start writing up units tests, as thanks to the abstraction, I can mock these types now. 2. I can get rid of the horrendously complex Utils class which was hiding away all of the 'ugly' logic. 3. This has furthermore allowed me to pass around the ProcessingEnvironment everywhere I need to mess with Elements/Types (which was basically everwhere), since it lives in the SourceX implementation files now. The processor-X and anotations-X modules compile now. I haven't tested whether this has borked the annotation processor as a whole yet, and also the Gradle setup might be a bit cursed atm. This commit simply marks the initial separation.
This means that the processor now behave exactly the same on both 1.5.0 and 2.0.0-SNAPSHOT. This commit also goes ahead and bumps the version.
2a229ed to
7d400ae
Compare
…not work as expected
#38) Co-authored-by: Strokkur24 <strokkur.24@gmail.com>
…declared anywhere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
New feature or request
platform
A new supported platform
publish snapshot
This PR will automatically publish snapshots
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #33.
Apparently, GitHub doesn't like it when you rename branches.
Anyways, I've decided to postpone modded support until later. Modded still needs to mature a bit and with the recent changes Fabric's been going through regarding the removal of obfuscations I believe it makes sense to wait a while.