Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Lionweb and the Starlasu implementation in Lionweb #83

Merged
merged 5 commits into from
Feb 20, 2025

Conversation

alessiostalla
Copy link
Member

@alessiostalla alessiostalla commented Feb 14, 2025

Addresses #79

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should have a JSON file saved somewhere and just load it here (just sharing a thought, I do not expect this to be changed in this PR)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well that would be handy

Copy link
Member

@ftomassetti ftomassetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All seems in order

@alessiostalla alessiostalla merged commit fc2b5c1 into master Feb 20, 2025
2 checks passed
@alessiostalla alessiostalla deleted the chore/update-lionweb branch February 20, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants