Accept download files URL without filter on local environment#3673
Open
aktolu wants to merge 1 commit intoStudio-42:masterfrom
Open
Accept download files URL without filter on local environment#3673aktolu wants to merge 1 commit intoStudio-42:masterfrom
aktolu wants to merge 1 commit intoStudio-42:masterfrom
Conversation
Member
|
@aktolu This PR is expected to be vulnerable to HTTP header injection attacks. Can you ensure it is secure against such attacks? |
Author
I don't think there will be any problem. If HTTP_HOST is sent as fake, Apache will not run the script due to host incompatibility. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.