Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable regal/startDebugging LSP method in Neovim #1175

Closed
wants to merge 1 commit into from

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Oct 5, 2024

Refs: neovim/nvim-lspconfig#3354

I created a pull request to nvim-lspconfig, it adds an LSP handler for regal/startDebugging method to regal default config.
Then, in this pull request, I'd like to enable regal/startDebugging method in Neovim to use Debug codelens feature.

Demo:
nvim-debug-codelens

I'm also planning to write an Neovim handler for regal/showEvalResult. I'll send a PR about it later.


Update:

I closed neovim/nvim-lspconfig#3354 because the handler depends on nvim-dap plugin.

Then, I updated nvim-dap-rego to bundle this handler into it.
rinx/nvim-dap-rego@7316f3f

@anderseknert
Copy link
Member

Wow, that looks amazing! 😻

@rinx rinx force-pushed the enable-debug-codelens-in-neovim branch from 169e332 to def416f Compare October 5, 2024 14:19
LSP handler for `regal/startDebugging` method is
introduced in rinx/nvim-dap-rego@7316f3f

Signed-off-by: Rintaro Okamura <[email protected]>
@rinx rinx force-pushed the enable-debug-codelens-in-neovim branch from def416f to 19acaa6 Compare October 6, 2024 02:44
@rinx
Copy link
Contributor Author

rinx commented Oct 6, 2024

In this pull request, I added Neovim to allow list of debug codelens feature.
However, I think it is better to allow users to control which feature is enabled.
I'm going to close this pull request and send another pull request to allow users to pass initialization options to enable debug codelens and select evaluate codelens output methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants