fix(sdk): reject malformed JSON from successful status responses - #264
Merged
karagozemin merged 1 commit intoAug 30, 2026
Merged
Conversation
CemAyyildiz
force-pushed
the
issue-242-status-json-parse
branch
from
August 30, 2026 17:15
5d78811 to
ff8fd3f
Compare
…-Rosa-Issue#242) Throw StatusJsonParseError for empty or invalid JSON on 2xx keeper status responses while preserving existing StatusApiError handling for non-2xx bodies. Add focused status-client tests and export the new error type. Closes Sub-Rosa-Issue#242 Co-authored-by: Cursor <cursoragent@cursor.com>
CemAyyildiz
force-pushed
the
issue-242-status-json-parse
branch
from
August 30, 2026 17:15
ff8fd3f to
59a1082
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
StatusJsonParseErrorfor successful keeper status responses with empty or malformed JSON bodies.StatusApiErrorbehavior for non-2xx responses, including malformed error payloads.status-client.test.tscoverage for valid, empty, malformed, and error-path responses.Closes #242
Test plan
pnpm --filter @sub-rosa/sdk testpnpm --filter @sub-rosa/sdk typecheckMade with Cursor