Skip to content

Fix escrow amounts without bigint precision loss - #283

Merged
karagozemin merged 2 commits into
Sub-Rosa-Issue:mainfrom
ayomustap:Format-escrow-amounts-without-bigint-precision-loss
Aug 31, 2026
Merged

Fix escrow amounts without bigint precision loss#283
karagozemin merged 2 commits into
Sub-Rosa-Issue:mainfrom
ayomustap:Format-escrow-amounts-without-bigint-precision-loss

Conversation

@ayomustap

Copy link
Copy Markdown

Summary

  • replace Number-based escrow display with exact bigint integer arithmetic
  • preserve the existing four-decimal display format
  • add regression coverage above Number.MAX_SAFE_INTEGER

Testing

  • pnpm --filter @sub-rosa/web test

Closes #278

@drips-wave

drips-wave Bot commented Aug 31, 2026

Copy link
Copy Markdown

@ayomustap Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@karagozemin
karagozemin merged commit d91e5af into Sub-Rosa-Issue:main Aug 31, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Format escrow amounts without bigint precision loss

2 participants