fix(agent): validate mandate timestamp ordering - #287
Merged
Conversation
Reject signed mandates whose issued, expiry, and commit timestamps are logically inconsistent. Enforce issuedAt <= commitDeadline <= expiresAt with exact equality allowed. Add focused tests for each invalid ordering and equality-boundary behavior. Closes Sub-Rosa-Issue#274
|
@olu-cmd Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #274
Goal
Reject signed mandates whose issued, expiry, and commit timestamps are logically inconsistent.
Changes
validateMandateTimestampOrderinginservices/agent/src/mandate.ts:52issuedAt <= commitDeadline <= expiresAtandissuedAt <= expiresAt>not>=) — defines exact boundary behaviorcreateSessionMandate(fail-fast) andverifySessionMandate(after signature, before expiry checks)MandateError:"issuedAt must be <= expiresAt","issuedAt must be <= commitDeadline","commitDeadline must be <= expiresAt"Tests
Added focused tests in
services/agent/src/mandate.test.ts:issuedAt > expiresAtissuedAt > commitDeadlinecommitDeadline > expiresAtissuedAt == commitDeadline == expiresAtcreateSessionMandaterejects ordering violations at creationpnpm --filter @sub-rosa/agent test— 15 passpnpm --filter @sub-rosa/agent typecheck— pass