fix(scripts): drop removed grant-scoring workspace from deploy-docs checker - #289
Merged
Merged
Conversation
…hecker The examples/grant-scoring package was removed from the workspace, but the deploy-document checker still listed its package.json in its hard-coded WORKSPACE_PKG_DIRS. Remove the obsolete entry so the checker's maintained package list stays in sync with the workspace layout. Generated with Codebuff 🤖 Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The deploy-document checker (
scripts/check-deploy-docs.mjs) still referenced the removedexamples/grant-scoringpackage in its hard-codedWORKSPACE_PKG_DIRSlist. Because the checker silently ignores entries whosepackage.jsonis missing (ENOENT→ continue), the stale entry had no effect at runtime but left outdated repository metadata in the checker and drifted from the workspace layout.This PR removes that obsolete entry so the checker's maintained package list stays in sync with
pnpm-workspace.yaml/ the current workspace.Changes
scripts/check-deploy-docs.mjs— removeexamples/grant-scoringfromWORKSPACE_PKG_DIRS.No active workspace or documentation content is changed.
Verification
pnpm docs:check→ PASS: all env-var and pnpm-command references resolve consistently.scripts/check-deploy-docs.test.mjs(node --test) → 7/7 pass (the checker's own test suite).Related
Closes #244