fix(web): reject empty hex input in the auditor decoder - #296
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The changes match the stated acceptance criteria and include targeted test coverage for the updated helper contract.
Pull request overview
This PR tightens the hexToBytes helper contract in the web app so that missing/empty hex payloads fail early with a clear "invalid hex string" error, improving the auditor decoding flow and aligning behavior with Issue #251.
Changes:
- Updated
hexToBytesto reject empty/whitespace-only/prefix-only inputs instead of returning an emptyUint8Array. - Added focused unit tests for invalid/valid hex decoding plus
bytesToHexencoding and round-trips. - Ensured the new test file is executed by the web workspace test script.
File summaries
| File | Description |
|---|---|
| apps/web/src/lib/hex.ts | Rejects empty decoded payloads while keeping existing validation and decoding behavior for valid hex. |
| apps/web/src/lib/hex.test.ts | Adds coverage for empty/prefix-only/invalid inputs and validates correct decoding/encoding behavior. |
| apps/web/package.json | Includes the new hex helper test in the web:test script’s explicit test file list. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
apps/web/src/lib/hex.ts): UpdatedhexToBytesto reject empty (""), whitespace-only (" "), and prefix-only ("0x","0X") strings withError("invalid hex string")instead of returning an empty byte array.apps/web/src/lib/hex.test.ts): Added comprehensive tests covering empty inputs, whitespace-only, prefix-only, odd length, invalid characters, valid prefixed/unprefixed strings, whitespace trimming, byte encoding, and round-trips.apps/web/package.json): Includedsrc/lib/hex.test.tsin the web workspace test command.Closes #251
Acceptance Criteria Checklist
pnpm web:test) and typecheck (pnpm web:typecheck) pass.Payout Routing
0xF46C9F6d70C50BF81ef3588AB523a90a594a2F89GCL6OXAMLD75BMTINA6EMRUDWK5THQUSHMYNLSNBCJAPZJHNYJTUNIBC