fix(web): reject empty auditor hex payloads (#251) - #340
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is narrowly scoped to the helper’s validation, matches the issue acceptance criteria, and includes test coverage wired into the normal web test command.
Pull request overview
Updates the web hex decoding helper to treat empty inputs as invalid so the auditor flow fails early with the existing “invalid hex string” error, and adds targeted tests that run in the normal web test script.
Changes:
- Reject empty, whitespace-only, and prefix-only (
0x/0X) inputs inhexToBytesusing the existing error message. - Add focused
node:testcoverage for invalid and valid prefixed/unprefixed hex decoding. - Include the new helper test file in
apps/web’stestscript.
File summaries
| File | Description |
|---|---|
| apps/web/src/lib/hex.ts | Adds an explicit empty-payload rejection to hexToBytes while preserving existing malformed-hex checks. |
| apps/web/src/lib/hex.test.ts | Introduces tests covering empty/whitespace/prefix-only rejection plus valid decode cases. |
| apps/web/package.json | Ensures the new hex helper tests run under the standard pnpm test/web test command. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #251.
Rejects empty, whitespace-only and prefix-only hex with the existing error; covers valid and malformed payloads in the normal web test command.
Validation: Web tests and typecheck pass on the combined verification branch.