ci: bound all existing workflow job durations (#252) - #341
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
All workflows in the repo now have finite job timeouts, and the changes are limited to adding timeout-minutes without altering job steps, triggers, permissions, or action versions.
Pull request overview
Adds explicit timeout-minutes limits to all existing GitHub Actions jobs to prevent indefinite runner consumption, aligning CI behavior with the new operational requirement from #252.
Changes:
- Set
timeout-minutes: 20for documentation link checking and TypeScript coverage jobs. - Set
timeout-minutes: 60for Rust contract and bindings-related jobs to accommodate cold builds.
File summaries
| File | Description |
|---|---|
| .github/workflows/docs-links.yml | Adds a 20-minute timeout to the docs link check job. |
| .github/workflows/coverage.yml | Adds a 20-minute timeout to the coverage job. |
| .github/workflows/contract.yml | Adds a 60-minute timeout to the contract test job. |
| .github/workflows/bindings-check.yml | Adds a 60-minute timeout to the bindings check job. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #252.
Sets 60-minute timeouts for cold Rust contract/binding jobs and 20-minute timeouts for coverage and documentation jobs. Steps, triggers, permissions and action versions remain unchanged.
Validation: Parsed every workflow with Ruby YAML; removing the timeout fields reproduces the original workflow objects.