chore: normalize script and web asset line endings (#254) - #343
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The PR narrowly updates .gitattributes to meet the stated acceptance criteria without modifying any source files.
Pull request overview
Updates .gitattributes to explicitly enforce LF line endings for additional first-party text formats (shell scripts, YAML, CSS, HTML) to prevent CRLF-related execution issues and noisy diffs, aligning with Issue #254’s acceptance criteria.
Changes:
- Add
text eol=lfrules for*.sh,*.yml,*.yaml,*.css, and*.html. - Preserve existing attribute rules and limit changes to the attributes file (no source renormalization).
File summaries
| File | Description |
|---|---|
.gitattributes |
Adds explicit LF enforcement for shell/YAML/CSS/HTML while leaving existing rules intact. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #254.
Adds explicit LF rules for shell, YAML, CSS and HTML. Existing rules are preserved; no source files are renormalized.
Validation: git check-attr confirms text normalization and LF for all added formats.