refactor(web): reuse the shared address formatter (#258) - #347
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change meets the stated acceptance criteria and only introduces a minor, non-blocking import-order convention issue.
Pull request overview
Refactors the useRoundSession hook to reuse the shared shortAddr address formatter from apps/web/src/lib/format.ts, removing a duplicate local implementation to prevent formatter drift across the web UI.
Changes:
- Import and use the shared
shortAddrformatter inuseRoundSession. - Remove the hook-local duplicate
shortAddrimplementation.
File summaries
| File | Description |
|---|---|
| apps/web/src/hooks/useRoundSession.ts | Replaces local shortAddr helper with the shared formatter and deletes the duplicate function. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+2
to
4
| import { shortAddr } from "../lib/format"; | ||
| import { Buffer } from "buffer"; | ||
| import { useEffect, useState } from "react"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #258.
Replaces the identical hook-local shortAddr function with the existing shared formatter. No other hook behavior changes.
Validation: Web tests and typecheck pass on the combined verification branch.