Fix reloader after PC update #229
Conversation
|
Let's see if the tests pass as it works locally at least. |
|
Okay, would have been nice but that breaks it for ST3. (macOS failures are unrelated.) |
|
Well, the first commit here tried the reloader from AutomaticPackagerReloader which failed for ST3. The second commit tries the reloader from GitSavvy. This passes (except for MacOs as expected). The GitSavvy reloader is simpler than the current (failing) version in this repo (I think), and like an order of magnitude simpler than the one on AutomaticPackageReloader. I'm not a fan of this getting more and more complicated as it is code basically nobody understands and can test thoroughly enough. I will probably switch |
Since the Package Control update to v4 our reloader is broken. E.g. `PackageManager()._is_dependency(pkg_name)` throws as it's not there anymore. (Note the leading `_` telling us to not use this method.) For now, copy the reloader from `GitSavvy` as it seems "newer" and works at least locally.
This commit removes `intercepting_imports`. As the whole package is reloaded and all top-level plugins are known, removing all sub-modules from sys.modules and re-importing the package and its top-level plugins is all which is needed to trigger re-importing all sub-modules in correct order. That's basically the strategy used by various packages already. The dummy package installation/removal is still required for ST to pickup new command and event listener classes. Solved issue: GitSavvy's reloader from PR #229 destroys a reloaded package's namespace module by clearing its __path__ or __spec__.module_search_locations. As a result it was no longer possible to import modules from sub directories, which caused test modules not to be importable any more. Thus "reload_package_on_testing": true caused all test cases to be vanished.
Fixes #228
Since the Package Control update to v4 our reloader is broken. E.g.
PackageManager()._is_dependency(pkg_name)throws as it's not there anymore. (Note the leading_telling us to not use this method.)For now, copy the reloader from
AutomaticPackageReloaderGitSavvyas it seems "newer" and works at least locally.