Refactor self tests #244
Merged
Refactor self tests #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit... 1. fixes `sublime.package_path()` called on import time, causing invalid or unexpected output paths being used. 2. use `setUp()` and `tearDow()` methods to setup and cleanup packages used for self tests in a batch per `TestCase` in order to prevent or reduce risk of possible race conditions or failing API calls due to too frequent package reloading or removing events. 3. optimize availability check for ColorSchemeUnit package
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit...
sublime.package_path()called on import time, causing invalid or unexpected output paths being used.setUp()andtearDow()methods to setup and cleanup packages used for self tests in a batch perTestCasein order to prevent or reduce risk of possible race conditions or failing API calls due to too frequent package reloading or removing events.