Fix plugin reloading before test start #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 2, 2024 20:41
This commit ... 1. refactors reloader's dummy plugin install/removal by using set_timeout() to check for dummy being loaded in order to not block the calling thread. 2. uses an `on_done` callback to continue operation after dummy has been removed. 3. always loads a dummy plugin as it is required to teach ST about new command and event instances. It does not work without that step. Before this commit the whole UI thread was blocked, causing dummy plugin not being reloaded until timeout was hit. Running tests on worker thread had other negative impacts. Reloading now behaves like "DefferableTextTestRunner" using set_timeout to schedule coroutines.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ...
on_donecallback to continue operation after dummy has been removed.Before this commit the whole UI thread was blocked, causing dummy plugin not being reloaded until timeout was hit. Running tests on worker thread had other negative impacts.
Reloading now behaves like "DefferableTextTestRunner" using set_timeout to schedule coroutines.