-
Notifications
You must be signed in to change notification settings - Fork 57
[Documentation:Developer] Add testing guide for external devs #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reads well to me, not sure how to verify it looks good on the site itself.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is reasonable. I see no issues with it.
The workflows run on PR commits, not all commits, so if you create a PR on a forked repository to that same repository, it will run the github action CI workflow. However, if you want to run the workflow just on a branch that is not a PR, you have to run the workflow manually. It is the same with the main repo. That being said, I see no real problems with this being added, however I think adding something to do with CI to either the title, or somewhere at the top to distinguish this from running tests locally. |
Added a page under testing to explain to process of running workflows as an external contributor